[Webkit-unassigned] [Bug 71143] [Meta] Master bug for sub-pixel layout branch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 9 10:08:38 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=71143
--- Comment #50 from WebKit Review Bot <webkit.review.bot at gmail.com> 2012-04-09 10:08:37 PST ---
Attachment 136239 did not pass style-queue:
Source/WebCore/rendering/LayoutTypes.h:39: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/rendering/LayoutTypes.h:40: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:81: wtf_ceil is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:538: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:540: This { should be at the end of the previous line [whitespace/braces] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:541: is_specialized is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:550: is_signed is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:551: is_integer is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:552: is_exact is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:556: round_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:559: min_exponent is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:560: min_exponent10 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:561: max_exponent is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:562: max_exponent10 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:564: has_infinity is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:565: has_quiet_NaN is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:566: has_signaling_NaN is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:567: has_denorm is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:568: has_denorm_loss is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:572: quiet_NaN is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:574: signaling_NaN is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:576: denorm_min is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:579: is_iec559 is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:580: is_bounded is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:581: is_modulo is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:583: Should have a space between // and comment [whitespace/comments] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:584: tinyness_before is incorrectly named. Don't use underscores in your identifieFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1
r names. [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:585: round_style is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/Length.h:33: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/platform/Length.h:112: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WebCore/platform/Length.h:116: Place brace on its own line for function definitions. [whitespace/braces] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:79: The parameter name "behavior" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 32 in 46 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list