[Webkit-unassigned] [Bug 83390] Web Inspector: CodeGeneratorInspector.py: do not expose raw methods from generated types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83390





--- Comment #5 from Peter Rybin <prybin at chromium.org>  2012-04-09 09:27:34 PST ---
> > Source/WebCore/ChangeLog:9
> > +        protected. InspectorObject and InspectorArray are reimplemented by "public Morozov" pattern.
> 
> This pattern doesn't seem to be used outside of post-Soviet countries, could you rephrase it?

Done

> > Source/WebCore/inspector/InspectorValues.cpp:671
> > +    *output = reinterpret_cast<InspectorObject*>(this);
> Why not static_cast as in other places?

Done

> > Source/WebCore/inspector/InspectorValues.cpp:683
> > +    return reinterpret_cast<InspectorObject*>(this);
> Same here and below.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.