[Webkit-unassigned] [Bug 83465] Web Inspector: split nodes and edges array in heap profiler serialization.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83465


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136214|review?                     |review-
               Flag|                            |




--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2012-04-09 06:16:11 PST ---
(From update of attachment 136214)
View in context: https://bugs.webkit.org/attachment.cgi?id=136214&action=review

Pleas add a test for the new snapshot format, r- for this.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:184
> +                this._array.push(0);

Can you move the meta node out of the array into its own element?

> Source/WebCore/inspector/front-end/HeapSnapshot.js:222
> +            // Add an extra node that points at the end of edges array.

Can you do this is a separate change?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.