[Webkit-unassigned] [Bug 83390] Web Inspector: CodeGeneratorInspector.py: do not expose raw methods from generated types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83390


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #136075|review?                     |review+
               Flag|                            |




--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2012-04-09 05:34:20 PST ---
(From update of attachment 136075)
View in context: https://bugs.webkit.org/attachment.cgi?id=136075&action=review

> Source/WebCore/ChangeLog:9
> +        protected. InspectorObject and InspectorArray are reimplemented by "public Morozov" pattern.

This pattern doesn't seem to be used outside of post-Soviet countries, could you rephrase it?

> Source/WebCore/inspector/InspectorValues.cpp:671
> +    *output = reinterpret_cast<InspectorObject*>(this);

Why not static_cast as in other places?

> Source/WebCore/inspector/InspectorValues.cpp:683
> +    return reinterpret_cast<InspectorObject*>(this);

Same here and below.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.