[Webkit-unassigned] [Bug 81786] Initial support fixed position elements in Qt WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81786





--- Comment #49 from Yael <yael.aharon at nokia.com>  2012-04-09 05:23:52 PST ---
(In reply to comment #48)
> (From update of attachment 136157 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136157&action=review
> 
> > Source/WebCore/page/FrameView.cpp:1707
> > +        if (m_frame->page()->settings()->acceleratedCompositingForFixedPositionEnabled())
> > +            updateFixedElementsAfterScrolling();
> 
> Is this setting really necessary? If we always enable it when using fixed-layout, it seems redundant. Would it be possible to instead check if accelerated compositing is enabled and the frameview has delegates-scrolling and fixed layout size set?

Sure, I can do that. Can you please explain the benefits of the change you are proposing? IMO, it is clearer as it is now, and if someone downstream decides at some point to not enable the setting, there is only one place that they need to change (in WebPage.cpp).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.