[Webkit-unassigned] [Bug 83254] [EFL] Support for Battery Status API on the WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83254





--- Comment #9 from Kihong Kwon <kihong.kwon at samsung.com>  2012-04-08 23:43:19 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> 
> > >> Source/WebKit/efl/ewk/ewk_battery_private.h:36
> > >> +void* ewk_battery_update_start(WebCore::BatteryClientEfl*);
> > > 
> > > It looks you don't add public APIs for batter status. Do you have plan to add public APIs ? If not so, I think that we don't need to add ewk_battery_xxx files.
> > 
> > You are right.
> > I will move these to ewk_private.h
> 
> If you won't add public APIs, why don't you implement functions of ewk_battery.cpp in BatteryClientEfl directly ?

You are right.
I will move all functionality of ewk_battery.cpp  to BatteryClientEfl.cpp.
That's better.
Thanks for comments.:)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.