[Webkit-unassigned] [Bug 82010] [Shadow DOM] InsertionPoint should have isActive() member function.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82010





--- Comment #4 from Takashi Sakamoto <tasak at google.com>  2012-04-08 20:45:13 PST ---
(In reply to comment #2)
> (From update of attachment 135751 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135751&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [Shadow DOM] InsertionPoint should have isActive() member function.
> 
> This change doesn't look just adding a member function. It also affects the behavior.
> Could you reflect that fact in this summary?

I see. I updated the summary. 

> 
> Also for the record, could you have a link to the spec in the changelog?

I added a link, https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#dfn-active-insertion-point.

> 
> > Source/WebCore/html/shadow/InsertionPoint.cpp:51
> > +    if (isShadowBoundary() && isActive()) {
> 
> My feeling is that isShadowBoundary() should contains isActive() since inactive node cannot be a boundary.

I see. I added isActive check to isShadowBoundary and removed from attach().

Best regards,
Takashi Sakamoto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.