[Webkit-unassigned] [Bug 83254] [EFL] Support for Battery Status API on the WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83254





--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-08 19:23:32 PST ---
(From update of attachment 136170)
View in context: https://bugs.webkit.org/attachment.cgi?id=136170&action=review

> Source/WebKit/efl/ChangeLog:9
> +        (charging, chargingTime, dischargingTime, level)

What it line 9 ? It looks line 9 is duplicated description.

> Source/WebKit/efl/ewk/ewk_battery.cpp:32
> +static Eina_Bool ewk_battery_status_update(void *data);

Move '*' to data type side.

> Source/WebKit/efl/ewk/ewk_battery.cpp:33
> +static void ewk_battery_status_get(void *data, void *reply_data, DBusError *error);

ditto.

> Source/WebKit/efl/ewk/ewk_battery.cpp:34
> +static void ewk_battery_status_client_set(void *data, void *reply_data, DBusError *error);

ditto.

> Source/WebKit/efl/ewk/ewk_battery.cpp:58
> +static Eina_Bool ewk_battery_status_update(void *data)

ditto.

> Source/WebKit/efl/ewk/ewk_battery.cpp:67
> +static void ewk_battery_status_get(void *data, void *reply_data, DBusError *error)

ditto.

> Source/WebKit/efl/ewk/ewk_battery.cpp:82
> +static void ewk_battery_status_client_set(void *data, void *reply_data, DBusError *error)

Do not use _ in local function.

> Source/WebKit/efl/ewk/ewk_battery.cpp:84
> +    E_Ukit_Get_All_Properties_Return* ret = static_cast<E_Ukit_Get_All_Properties_Return*>(reply_data);

Do not use abbreviation. ret -> ?

> Source/WebKit/efl/ewk/ewk_battery_private.h:36
> +void* ewk_battery_update_start(WebCore::BatteryClientEfl*);

It looks you don't add public APIs for batter status. Do you have plan to add public APIs ? If not so, I think that we don't need to add ewk_battery_xxx files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.