[Webkit-unassigned] [Bug 83227] [chromium] wrong justification for arabic/persian page in cr-win

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83227





--- Comment #24 from Kenichi Ishibashi <bashi at chromium.org>  2012-04-08 18:43:11 PST ---
(From update of attachment 136121)
View in context: https://bugs.webkit.org/attachment.cgi?id=136121&action=review

LGTM if all layout tests are passed.

>> Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp:219
>> +        shaping.m_justify.resize(shaping.glyphLength());
> 
> Ah, for performance improvement, I could do a memcpy on shaping.m_justify and only re-assign m_justify for space character in the following loop and the loop could early exit when additionalSpace ==0.

To do it, I think you can "shaping.m_justify = shaping.m_advance" here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.