[Webkit-unassigned] [Bug 82010] [Shadow DOM] InsertionPoint should have isActive() member function.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82010


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135751|review?                     |review-
               Flag|                            |




--- Comment #2 from Hajime Morrita <morrita at google.com>  2012-04-08 17:40:02 PST ---
(From update of attachment 135751)
View in context: https://bugs.webkit.org/attachment.cgi?id=135751&action=review

> Source/WebCore/ChangeLog:3
> +        [Shadow DOM] InsertionPoint should have isActive() member function.

This change doesn't look just adding a member function. It also affects the behavior.
Could you reflect that fact in this summary?

Also for the record, could you have a link to the spec in the changelog?

> Source/WebCore/html/shadow/InsertionPoint.cpp:51
> +    if (isShadowBoundary() && isActive()) {

My feeling is that isShadowBoundary() should contains isActive() since inactive node cannot be a boundary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.