[Webkit-unassigned] [Bug 83437] Command-line jsc's exception handling should be rationalized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83437





--- Comment #3 from Filip Pizlo <fpizlo at apple.com>  2012-04-08 13:46:19 PST ---
(In reply to comment #2)
> (From update of attachment 136156 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=136156&action=review
> 
> > Source/JavaScriptCore/jsc.cpp:532
> >          if (dump) {
> > -            if (evaluationException)
> > -                printf("Exception: %s\n", evaluationException.toString(globalObject->globalExec())->value(globalObject->globalExec()).utf8().data());
> > -            else
> > +            if (!evaluationException)
> 
> Now that there’s no else clause inside you can just write
>     if (dump && !evaluationException)

Good point, thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.