[Webkit-unassigned] [Bug 83426] Don't expose internal CSSValues in API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 7 14:13:11 PDT 2012


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #136137|review?                     |review+
               Flag|                            |

--- Comment #8 from Andreas Kling <kling at webkit.org>  2012-04-07 14:13:10 PST ---
(From update of attachment 136137)
View in context: https://bugs.webkit.org/attachment.cgi?id=136137&action=review

Very cool. r=me.
(Though you'll need to do something about the win failure.)

> Source/WebCore/css/CSSImageSetValue.cpp:146
> +    // Non-CSSValueList data is not accesible through CSS OM, no need to clone.

Typo accessible.

> Source/WebCore/css/CSSValue.h:38
> +// Please don't expose more CSSValue types to the web.

Hear hear. Perhaps we could even get rid of WebKitCSSTransformValue.idl and WebKitCSSFilterValue.idl.

> Source/WebCore/css/RGBColor.cpp:42
> +    // Unique instances are safe.

Don't think this comment is needed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list