[Webkit-unassigned] [Bug 80431] RenderImage ignores its percent width/height when setContainerSizeForRenderer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 7 01:25:03 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=80431


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131059|review?                     |review+
               Flag|                            |




--- Comment #16 from Nikolas Zimmermann <zimmermann at kde.org>  2012-04-07 01:25:01 PST ---
(From update of attachment 131059)
View in context: https://bugs.webkit.org/attachment.cgi?id=131059&action=review

r=me. I forgot to write down here that the bug wasn't really fixed with Yongs patch.
It turns out it was much more complex, to get it right, see bug 81631. This combined with Yong patch fixes the problem for real, still his test is good and should be landed.

> LayoutTests/svg/as-image/svg-as-image-with-relative-size-expected.html:10
> +        <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" height="100%" width="100%">

All attributes except xmlns are unnecessary here, please remove them.

> LayoutTests/svg/as-image/svg-as-image-with-relative-size.html:10
> +        <!-- The following svg has a width of 1px and a height of 1px and draw a rect inside.

s/draw/draws/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list