[Webkit-unassigned] [Bug 83227] [chromium] wrong justification for arabic/persian page in cr-win

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83227


Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135731|0                           |1
        is obsolete|                            |
 Attachment #135782|0                           |1
        is obsolete|                            |
 Attachment #135946|0                           |1
        is obsolete|                            |
 Attachment #135967|0                           |1
        is obsolete|                            |
 Attachment #135946|review?                     |
               Flag|                            |
 Attachment #136121|                            |review?
               Flag|                            |




--- Comment #22 from Xiaomei Ji <xji at chromium.org>  2012-04-06 19:29:26 PST ---
Created an attachment (id=136121)
 --> (https://bugs.webkit.org/attachment.cgi?id=136121&action=review)
patch w/ layout test

sorry that I found another 2 bugs in the CL.
1. the numSpaces should be counted within one TextRun, across m_runs so that padding are evenly distributed inside TextRun.
2. sine shaping.m_justify is used not only in draw() but also in advanceForItem(), I am keeping m_justify here with the value adjusted to account for extra spacing.

related test is added.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.