[Webkit-unassigned] [Bug 73083] Fix the Frame Leak Attack

Fri Apr 6 13:25:28 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=73083

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135923|review?                     |review+
               Flag|                            |

--- Comment #42 from Adam Barth <abarth at webkit.org>  2012-04-06 13:25:28 PST ---
(From update of attachment 135923)
View in context: https://bugs.webkit.org/attachment.cgi?id=135923&action=review

This patch looks great.  I would just add some more information to the ChangeLog.

> Source/WebCore/ChangeLog:9
> +        Match FF behaviour: FF has done this for all iframes for a year now, but our change
> +        is less disruptive in that it only does this in the cross-orgin case.

These two sentences confuse me.  Are we matching Firefox's behavior or not?  If we're not matching their behavior, we should explain why in more detail.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.