[Webkit-unassigned] [Bug 81786] Initial support fixed position elements in Qt WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81786





--- Comment #43 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-04-06 05:46:53 PST ---
(From update of attachment 135972)
View in context: https://bugs.webkit.org/attachment.cgi?id=135972&action=review

> ChangeLog:3
> +        Initial support for fixed position elements in Qt WebKit2

As you call it initial you should state what is supported and what is pending.

> Source/WebCore/page/FrameView.cpp:1707
> +        if (m_frame->page()->settings()->acceleratedCompositingForFixedPositionEnabled())
> +            updateFixedElementsAfterScrolling();

Maybe we should do the check inside the method instead?

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:516
> +void TextureMapperLayer::setScrollPositionDelta(const IntPoint& delta)
> +{
> +    m_scrollPositionDelta = delta;

Maybe this method deserves a comment?

> Source/WebKit2/UIProcess/LayerTreeHostProxy.messages.in:31
> +    DidUpdateScrollPosition(WebCore::IntPoint position)

I believe WK2 mostly uses Change... like DidChangeScrollPosition

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:76
> +static IntPoint normalizedScrollPosition(const IntPoint& scrollPosition, const IntRect& visibleContentRect, const FloatSize& contentSize)

boundedScrollPosition?

> Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:267
> +    // These conditions must match the condisions in RenderLayerCompositor::requiresCompositingForPosition.

conditions*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.