[Webkit-unassigned] [Bug 83349] [BlackBerry] We shouldn't set empty Content-Length & Content-Type to request's headers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83349





--- Comment #3 from Jason <jason.liu at torchmobile.com.cn>  2012-04-06 01:20:38 PST ---
(In reply to comment #2)
> (From update of attachment 135979 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135979&action=review
> 
> > Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:210
> > +    m_httpHeaderFields.remove("Content-Length");
> > +
> > +    if (url().protocolInHTTPFamily())
> > +        m_platformRequestUpdated = false;
> 
> Just ASSERT(url().protocolInHTTPFamily()) instead of *if* branch?
> 
> > Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:220
> > +    m_httpHeaderFields.remove("Content-Type");
> > +
> > +    if (url().protocolInHTTPFamily())
> > +        m_platformRequestUpdated = false;
> 
> Ditto.

Why don't we do as clearHTTPReferrer? 
If we remove this *if* branch, "updateResourceRequest();" can be moved, too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.