[Webkit-unassigned] [Bug 83342] New: suggest-reviewers shouldn't break in the presence of moved files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 18:27:33 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=83342

           Summary: suggest-reviewers shouldn't break in the presence of
                    moved files
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fischman at chromium.org


Apparently webkit-patch upload's --suggest-reviewers feature is broken in the presence of moved (removed?) files.  After moving a test & its expectation from LayoutTests/http/tests/media to LayoutTests/media the upload failed like this:

$ ./Tools/Scripts/webkit-patch upload --request-commit --suggest-reviewers 83296
Total errors found: 0 in 4 files
Was that diff correct? [Y/n]:
Fetching: https://bugs.webkit.org/show_bug.cgi?id=83296&ctype=xml
Path /usr/local/google/fischman/src/chromium/src/third_party/WebKit/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt does not exist.
Path /usr/local/google/fischman/src/chromium/src/third_party/WebKit/LayoutTests/http/tests/media/media-can-load-when-hidden-expected.txt does not exist.

Removing the --suggest-reviewers option made it work just fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list