[Webkit-unassigned] [Bug 83227] [chromium] wrong justification for arabic/persian page in cr-win

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83227





--- Comment #19 from Kenichi Ishibashi <bashi at chromium.org>  2012-04-05 17:55:02 PST ---
(From update of attachment 135946)
View in context: https://bugs.webkit.org/attachment.cgi?id=135946&action=review

LGTM. Thank you for working on this!
Kent-san, could you do formal-review?

>> Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp:198
>> +        Shaping& shaping = m_shapes[run];
> 
> I also fixed a bug here. since spacing and advancing are done visually from left to right. We should using visual order here instead of treating 'run' as logical index and doing m_shapes[m_screenOrder[run]]. It might be better to change 'run' to 'visualIndex', and I will see whether I can have a simple case reduction.

Ok. (I'm not sure how justification should work for RTL text, though)

> Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp:207
> +                spaceCharacters[shaping.m_logs[i]] =  characterIndex;

nit: two spaces after '='.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.