[Webkit-unassigned] [Bug 81786] Initial support fixed position elements in Qt WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81786





--- Comment #40 from Yael <yael.aharon at nokia.com>  2012-04-05 15:11:11 PST ---
(In reply to comment #37)
> (From update of attachment 135747 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135747&action=review
> > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:514
> > +void TextureMapperLayer::setScrollPositionDelta(const IntPoint& delta)
> 
> Delta -> Offset
This is actually a delta and not an offset. Since you asked me to do the calculation only once, and set to all layers, I calculated the delta between scroll offset of the web process and scroll offset of the ui process and add that to the position of the transform.

> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:518
> > +    m_transform.setPosition(m_state.pos + m_scrollPositionDelta);
> 
> Add a scrollOffset to LayerTransform instead of making this calculation here.
> This would break when the position changes without the delta changing.
> 
If the position changes, we will sync the layers again and will re-calculate. I will add a test that changes the position dynamically, to show that this is not breaking.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.