[Webkit-unassigned] [Bug 83214] [Chromium] moving a cursor on a misspelled word should not remove a misspelled underline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83214


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135691|review?                     |review+
               Flag|                            |




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2012-04-05 13:46:51 PST ---
(From update of attachment 135691)
View in context: https://bugs.webkit.org/attachment.cgi?id=135691&action=review

>>> Source/WebCore/editing/Editor.cpp:2931
>>> +#else
>> 
>> Does this need to be guarded inside Chromium at all? Doesn't other port that implements async spell checking want this fix as well?
> 
> Unfortunately, it loses compatibility with AppKit on Snow Leopard. Even though AppKit of Snow Leopard can spellcheck text in the background when we paste text, it deletes misspelling markers when we move a cursor.

Interesting. It seems acceptable to land this patch as is but we should figure out a better way of abstracting these port-specific behaviors.
Maybe we want some client callback here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.