[Webkit-unassigned] [Bug 83284] [chromium] Add support for Battery Status API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 08:59:50 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=83284





--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-04-05 08:59:49 PST ---
Attachment 135835 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
Source/WebKit/chromium/src/BatteryClientChromium.h:48:  The parameter name "status" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/BatteryClientChromium.h:62:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit/chromium/src/BatteryClientChromium.h:64:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit/chromium/src/BatteryClientChromium.h:65:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit/chromium/src/BatteryClientChromium.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/chromium/src/BatteryClientChromium.cpp:96:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit/chromium/src/BatteryClientChromium.cpp:98:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit/chromium/public/WebBatteryStatus.h:41:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit/chromium/public/WebBatteryStatus.h:62:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit/chromium/public/WebBatteryStatus.h:64:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 11 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list