[Webkit-unassigned] [Bug 83121] [EFL] Add setting API for allow universal/file access from file URLs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83121


Tomasz Morawski <t.morawski at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.morawski at samsung.com




--- Comment #6 from Tomasz Morawski <t.morawski at samsung.com>  2012-04-05 01:59:02 PST ---
(In reply to comment #2)
> (From update of attachment 135526 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135526&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:2445
> > +Eina_Bool ewk_view_setting_allow_universal_access_from_file_urls_set(Evas_Object* ewkView, Eina_Bool enable)
> 
> I'm not sure whether we add new APIs for this setting obstinately. According to I take a look other ports, almost ports don't support this feature as APIs. If you don't think that EFL port should support this setting feature, I think it is better to move from ewk_view to DumpRenderTreeSupportEfl for just testing.

I take a look other ports too it seems that Chromium port and win port use this setting as API. Please see:

Source/WebKit/chromium/public/WebSettings.h
Source/WebKit/win/WebPreferences.h

After adding this settings, the DRT code will look more clear and objective.
Anyway, after removing all setting functions by replace it by single get/set setting functions will resolve your concerns related to API changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.