[Webkit-unassigned] [Bug 83137] [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 5 01:46:00 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=83137
--- Comment #5 from ChangSeok Oh <kevin.cs.oh at gmail.com> 2012-04-05 01:46:00 PST ---
(From update of attachment 135768)
View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review
Thanks for the review!
>> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27
>> + window[testsList[testCounter++]]();
>
> The change looks OK, but we can simplify the code more, like this:
>
> var testsList = [runObjectTest, cleanupAndRunNext, ...]; // An array of functions (not function names)
>
> ... else {
> (testsList[testCounter++])();
> }
Done. :)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list