[Webkit-unassigned] [Bug 83137] [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83137


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135768|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Kentaro Hara <haraken at chromium.org>  2012-04-05 00:52:26 PST ---
(From update of attachment 135768)
View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review

> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27
> +        window[testsList[testCounter++]]();

The change looks OK, but we can simplify the code more, like this:

var testsList = [runObjectTest, cleanupAndRunNext, ...];  // An array of functions (not function names)

... else {
  (testsList[testCounter++])();
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.