[Webkit-unassigned] [Bug 82577] Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82577





--- Comment #16 from Filip Pizlo <fpizlo at apple.com>  2012-04-04 18:13:19 PST ---
(In reply to comment #15)
> Filip, any thoughts on Comment #6, Comment #8, and Comment #10 ?

#6, #8: see my previous reply.

#10: spoke to Alexey in person. He still views Nikolas' style as being somewhat unusual. I still view it as being desirable, because it reduces #ifdef's, which make the code harder to read.

I don't think these stylistic issues are so grotesque as to preclude this patch from landing.

I don't think that using "if (fooBar()) { ... }" makes it any harder to remove the code than using "#if FOO_BAR \n ... \n #endif".

I don't think there is a performance implication to using "if (fooBar())" instead of "#if FOO_BAR", since the function in question is static inline.

I haven't heard further replies from you or Eric, and nobody flagged the patch as r-. This led me to believe that you didn't feel strongly enough about your views on the style of if statement being used to block the patch from landing as-is. The patch has sat around for long enough that I decided that it would be better to let the patch land than to continue arguing about these small things.

If you do feel strongly about preferring "#if FOO_BAR" over "if (fooBar())" then I suppose there is still time to r- the patch. It's your call. I like the patch as is and would rather err on the side of letting it land but I don't have strong feelings either way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.