[Webkit-unassigned] [Bug 83227] [chromium] wrong justification for arabic/persian page in cr-win

Wed Apr 4 16:33:30 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=83227

Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135716|                            |review?
               Flag|                            |

--- Comment #1 from Xiaomei Ji <xji at chromium.org>  2012-04-04 16:33:30 PST ---
Created an attachment (id=135716)
 --> (https://bugs.webkit.org/attachment.cgi?id=135716&action=review)
patch w/ layout test

the patch mostly matches justify in WebKit's UniscribeController::shapeAndPlaceItem.

But there are 2 things that I do not understand:
1. justify() is called per run, I think. Then, inside justify(), can we work justification on m_runs?, they should not be the same unless m_runs.size() always equals to 1. But the rendered results looks ok on the page I tested. I need to look into further.
2. in UniscribeController::shapeAndPlaceItem, the mapping of spaceCharacter is assigned as:
spaceCharacters[clusters[k]] = m_currentCharacter + k + item.iCharPos;
I do not understand why it is not "spaceCharacters[clusters[k]] = k + item.iCharPos;"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.