[Webkit-unassigned] [Bug 71143] [Meta] Master bug for sub-pixel layout branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71143





--- Comment #39 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-04-04 15:40:24 PST ---
Attachment 135700 did not pass style-queue:

Source/WebCore/rendering/LayoutTypes.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/rendering/LayoutTypes.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/rendering/RenderView.h:204:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:543:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:545:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:546:  is_specialized is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:555:  is_signed is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:556:  is_integer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:557:  is_exact is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:561:  round_error is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:564:  min_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:565:  min_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:566:  max_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:567:  max_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:569:  has_infinity is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:570:  has_quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:571:  has_signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:572:  has_denorm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:573:  has_denorm_loss is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:577:  quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:579:  signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:581:  denorm_min is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:584:  is_iec559 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:585:  is_bounded is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:586:  is_modulo is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:588:  Should have a space between // and comment  [whitespaFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1
ce/comments] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:589:  tinyness_before is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:590:  round_style is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/Length.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/Length.h:112:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/Length.h:116:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:79:  The parameter name "behavior" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 33 in 53 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.