[Webkit-unassigned] [Bug 82690] Pressing enter on blank line after bullet deletes entire bulleted line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82690





--- Comment #4 from yi shen <yi.4.shen at nokia.com>  2012-04-04 14:11:48 PST ---
Thanks for the review and the suggestion. I agree that we should use isListItem instead, which is more clear :)
(In reply to comment #2)
> (From update of attachment 135594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135594&action=review
> 
> > Source/WebCore/editing/CompositeEditCommand.cpp:1278
> > -        if (emptyListItem->renderer()->previousSibling())
> > +        if (emptyListItemRenderer->previousSibling())
> 
> Why can't we just call isListItem on the previous node?
> 
> > Source/WebCore/editing/CompositeEditCommand.cpp:1290
> > -        removeNode(emptyListItem->renderer()->previousSibling() ? emptyListItem : listNode);
> > +        removeNode(emptyListItemRenderer->previousSibling() ? emptyListItem : listNode);
> 
> Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.