[Webkit-unassigned] [Bug 78095] [GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78095





--- Comment #15 from Martin Robinson <mrobinson at webkit.org>  2012-04-04 08:39:59 PST ---
(From update of attachment 135598)
View in context: https://bugs.webkit.org/attachment.cgi?id=135598&action=review

Looks good, though I've pointed out a few small nits below.

> Source/WebCore/Modules/webaudio/AudioContext.cpp:186
> +    WebCore::initializeGStreamer();

You are already in the WebCore namespace here, right?

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:22
> +
> +#include "GStreamerUtilities.h"

Extra newline here.

> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:27
> +#include <wtf/gobject/GOwnPtr.h>
> +
> +#if USE(GSTREAMER)
> +#include <gst/gst.h>

I think I'd prefer the includes to all be on one side of the guard.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:196
> +    GRefPtr<GstElementFactory> factory = gst_element_factory_find(gPlaybinName);
> +    if (factory)

I think you could actually do:

GRefPtr<GstElementFactory> factory = gst_element_factory_find(gPlaybinName);
return factory;

> Source/autotools/symbols.filter:138
> +_ZN7WebCore19initializeGStreamerEv;

Why is this necessary? It should only be required if yo uare using this function outside of libwebkitgtk, I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.