[Webkit-unassigned] [Bug 83030] [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83030





--- Comment #2 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-04 07:58:50 PST ---
(From update of attachment 135326)
View in context: https://bugs.webkit.org/attachment.cgi?id=135326&action=review

Repeating what I said on IRC for future-proofness: this approach is fine, but it ends up emitting duplicate signals in cases in which we already have, for example, ewk_frame_load_firstlayout_nonempty_finished and ewk_frame_load_provisional. Even though I like the enum approach better, adopting it will probably break existing code hard, so it'd be good to leverage the work that's already done here.

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:341
> +    if ((loadStatus == EWK_FRAME_LOAD_FINISHED || loadStatus == EWK_FRAME_LOAD_FAILED)
> +        && frame == topLoadingFrame)

WebKit in general doesn't have a hard character limit, so putting the if in a single line is just fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.