[Webkit-unassigned] [Bug 82860] [EFL] Add setting API for author and user styles.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82860





--- Comment #4 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-04 07:02:05 PST ---
(From update of attachment 135030)
View in context: https://bugs.webkit.org/attachment.cgi?id=135030&action=review

> LayoutTests/ChangeLog:8
> +        Enable test connected with seAuthorAndUserStylesEnabled.

Typo in the function name.

> LayoutTests/ChangeLog:11
> +        * platform/efl/fast/css/disabled-author-styles-expected.txt: Added.

Just to confirm, this was created via run-webkit-tests (ie. it used the dependencies built with jhbuild), right?

>>> Source/WebKit/efl/ewk/ewk_view.h:1950
>>> +EAPI Eina_Bool    ewk_view_setting_enable_author_and_user_styles_get(const Evas_Object *o);
>> 
>> I'm not sure if we need to add this API for application. It seems to me that this setting feature is only added by chromium port. Could you let me know why we need to add this API ?
>> If we don't need to add this API, in my opinion, you can add this feature to DumpRenderTreeSupportEFL.
> 
> In general I added this setting to pass layout test. If you feel that it's not needed to publish such an API I can change it. What is others opinion?

Personally, it's unclear to me what "enabling author and user styles" actually means, and the Qt and Win ports don't expose this functionality to end users.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.