[Webkit-unassigned] [Bug 14959] No back forward entry added for pages created in javascript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=14959





--- Comment #37 from Pravin D <pravind.2k4 at gmail.com>  2012-04-04 04:17:41 PST ---
(In reply to comment #30)
> > Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:129
> > +    UString firstString = exec->argument(0).toString(exec)->value(exec);
> 
> What if toString throws an exception?

Have added check to test if "argument(0)" is Undefined or not.

> > Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:132
> > +    if (mimeType != "text/plain")
> 
> This check doesn't seem like it can be right.  What if the mimeType is "text/plain; charset=utf-8" ?

mime type is extracted by checking if the type string contains the "MIMETYPE" in a case insensitive way.

Also changed the structure/functions from the previous patch. Now there is one Document::open(mime, replace, ownerDoc) which is called from JSHTMLDocument instead of the regular Document::open(ownerDoc). Document::open(mime, replace, ownerDoc)  in turn calls the Document::open(ownerDoc) and also handles adding/replacing history item contents through FrameLoader. Document::open(mime, replace, ownerDoc) is also responsible in deciding if a history item must be modified/added for that particular frame.

Moved the actual History Item manipulation from FrameLoader to HistoryController class

PS:
I have 2 seperate patches, one for the code changes and one for the test cases. EWS was/is failing for all platforms and style. So thought adding code changes and Test cases could help... Maybe not so !!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.