[Webkit-unassigned] [Bug 82986] jsr/sret should be removed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 20:35:06 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82986





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2012-04-03 20:35:06 PST ---
(In reply to comment #4)
> (From update of attachment 135495 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135495&action=review
> 
> emitComplexJumpScopes is maybe not my favorite function.
> 
> r=me
> 
> > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2177
> > +                while (m_labelScopes.size() > finallyContext.labelScopesSize)
> > +                    m_labelScopes.removeLast();
> 
> m_labelScopes.shrink(finallyContext.labelScopesSize) should suffice here.

SegmentedVector is shrinkless!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list