[Webkit-unassigned] [Bug 83108] Web Inspector: JSC Crash inspecting node with object event listener

Tue Apr 3 20:11:34 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=83108

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135493|review?                     |review-
               Flag|                            |

--- Comment #4 from Geoffrey Garen <ggaren at apple.com>  2012-04-03 20:11:34 PST ---
(From update of attachment 135493)
View in context: https://bugs.webkit.org/attachment.cgi?id=135493&action=review

> Source/WebCore/bindings/js/ScriptEventListener.cpp:-103
> -    JSLock lock(SilenceAssertionsOnly);

Why did you remove this lock?

> Source/WebCore/bindings/js/ScriptEventListener.cpp:125
> +    if (!isJSFunction(jsObject))

No need to check isJSFunction. jsCast<T> will return 0 if the cast fails.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.