[Webkit-unassigned] [Bug 73638] [EFL] Implement 'registerProtocolHandler' function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73638





--- Comment #18 from Dongwoo Joshua Im <dw.im at samsung.com>  2012-04-03 19:46:13 PST ---
(In reply to comment #17)
> (From update of attachment 135467 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135467&action=review
> 
> > Source/WebKit/efl/ewk/ewk_custom_handlers.cpp:29
> > +    evas_object_smart_callback_call(data->o, "protocolhandler,register", static_cast<void*>(data));
> 
> Oops, I'm sorry. It looks you don't write this signal to signal list in ewk_view.h
> 

Oh.. should I add that in the ewk_view.h? I will. Thanks.


> > Source/WebKit/efl/ewk/ewk_view.h:289
> > +struct _Ewk_Custom_Handlers_Data {
> 
> I would like to confirm this struct again. Will you add new API to set this data by application ? Because, as you know, if there is no API to set protocol handler, we don't need to open this struct.


Application will not set any value to the members of this structure.
Application will only "read" the value.
Is setter needed anyway?


By the way, I didn't make getter, as well.
I open this structure, so I think the application can get the value by access to the structure without getter.

Do you want me to make getter?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.