[Webkit-unassigned] [Bug 82853] [GTK] Add filesystem API interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 19:24:38 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82853





--- Comment #3 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-04-03 19:24:37 PST ---
(In reply to comment #2)
> (From update of attachment 135330 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135330&action=review
> 
> I am not sure I understand the rationale for creating these new classes? What problem are we trying to solve here? I don't like these empty shells tbh, I'd rather have implementation of stuff in the patches, it makes it way easier to understand what's intended, what's being solved and so on.
> 
> > Source/WebCore/ChangeLog:24
> > +        * platform/gtk/AsyncFileSystemCallbacksGtk.cpp: Added. This is an implement of AsyncFileSystemCallbacks.
> 
> implement -> implementation

Thanks for the review.
I think it's better to split the patch into some parts, since the full patch is too huge to understand.
Well, if you don't mind, I'm willing to submit the full patch again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list