[Webkit-unassigned] [Bug 83098] Offlineasm ARM backend uses the wrong mnemonic for multiply

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83098





--- Comment #2 from Darin Adler <darin at apple.com>  2012-04-03 17:43:59 PST ---
(From update of attachment 135469)
View in context: https://bugs.webkit.org/attachment.cgi?id=135469&action=review

> Source/JavaScriptCore/offlineasm/armv7.rb:781
>              if operands.size == 2 or operands[0] == operands[2] or operands[1] == operands[2]
> -                emitArmV7("muls", operands)
> +                emitArmV7("mul", operands)

Taking your change log comment literally, it seems this should stay “muls” since it’s passing only two operands.

> Source/JavaScriptCore/offlineasm/armv7.rb:784
> -                $asm.puts "muls #{operands[2].armV7Operand}, #{operands[2].armV7Operand}, #{operands[1].armV7Operand}"
> +                $asm.puts "mul #{operands[2].armV7Operand}, #{operands[2].armV7Operand}, #{operands[1].armV7Operand}"

This change matches your change log comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.