[Webkit-unassigned] [Bug 82643] [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82643


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135380|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-04-03 12:06:56 PST ---
(From update of attachment 135380)
View in context: https://bugs.webkit.org/attachment.cgi?id=135380&action=review

Looks good, can be improved a bit still.

> Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.cpp:172
> +    if (match) {

Can combine ttese two lines.

> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:815
>      WTF::String nameStr = jsStringRefToWebCoreString(target);

Probably no need for WTF::

> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:838
> +    return BlackBerry::WebKit::DumpRenderTree::currentInstance()->page()->findNextString(nameStr.utf8().data(), !(options & WebCore::Backwards), !(options & WebCore::CaseInsensitive), true, true);

You probably want to explain what true params do here (true /* wrap */ etc).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.