[Webkit-unassigned] [Bug 82192] [EFL][DRT] Catch the "resource, request, willsend" signal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 04:54:55 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82192





--- Comment #19 from Raphael Kubo da Costa <rakuco at FreeBSD.org>  2012-04-03 04:54:55 PST ---
(From update of attachment 135306)
View in context: https://bugs.webkit.org/attachment.cgi?id=135306&action=review

Thanks for the work, looks almost good to me.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:-176
> -    // We want to distinguish between a request for a document to be loaded into
> -    // the main frame, a sub-frame, or the sub-objects in that document (via Chromium).

Please keep the comment in the code for the chunk it's related to to be easier to understand.

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:303
> +        return;

`return' not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list