[Webkit-unassigned] [Bug 73638] [EFL] Implement 'registerProtocolHandler' function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73638





--- Comment #14 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-03 04:30:20 PST ---
(From update of attachment 135307)
View in context: https://bugs.webkit.org/attachment.cgi?id=135307&action=review

> Source/WebKit/ChangeLog:8
> +        The registerProtocolHandler() method allows Web sites to registera themselves

Typo ? registera -> register ?

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:600
> +    data->o = ewkView;

It looks this is good solution to split ewk_custom_handler.cpp from ewk_view.cpp. I would like to know kubo's opinion about this.

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:608
> +void customHandlersDataDelete(Ewk_Custom_Handlers_Data* data)

It seems to me it is good to use non-member function as static or to use it as private member function.

> Source/WebKit/efl/ewk/ewk_view.h:290
> +    Evas_Object *o;

In my opinion, you need to add description for each field.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.