[Webkit-unassigned] [Bug 82989] Auto-size may not work on first load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82989


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135246|review?                     |review-
               Flag|                            |




--- Comment #4 from David Levin <levin at chromium.org>  2012-04-02 18:12:59 PST ---
(From update of attachment 135246)
View in context: https://bugs.webkit.org/attachment.cgi?id=135246&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests. (OOPS!)
> 
> You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]

What style queue said.

> Source/WebCore/dom/Document.cpp:2382
> +    m_processingLoadEvent = false;

There are two places where "return" is done above without setting this to false above.

I wonder if we should use TemporaryChange here (although that can be tricky because where you want to do the reset isn't the end of a scope, so you either need to create a new scope, add a method to reset it early or allocate a TemporaryChange into an OwnPtr and then clear it here).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.