[Webkit-unassigned] [Bug 74680] [Plugins GTK/QT] Signed to Unsigned Conversion Error

Mon Apr 2 18:08:15 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=74680

Kwangmin Bang <justine.bang at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #119550|0                           |1
        is obsolete|                            |
 Attachment #135250|                            |review?, commit-queue?
               Flag|                            |

--- Comment #6 from Kwangmin Bang <justine.bang at samsung.com>  2012-04-02 18:08:15 PST ---
Created an attachment (id=135250)
 --> (https://bugs.webkit.org/attachment.cgi?id=135250&action=review)
Signed to Unsigned Conversion Error

rebase the patch.

When tested webkit for desktop, it's not need this patch.
My testing environment is using floating viewport for mobile browser( view is bigger than device screen).
For getting m_windowRect, I'm using contentsToScreen instead of contentsToWindow.
so, m_windowRect.x or y can be the negative.

However, I think these codes are a basic problem about conversion. ( unsigned = signed )
this patch will prevent "Signed to Unsigned Conversion Error" and remove the warning in build time.

How do you think about my opinion ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.