[Webkit-unassigned] [Bug 59367] [GTK] DRT missing didRunInsecureContent notification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 13:30:37 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=59367





--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2012-04-02 13:30:34 PST ---
(From update of attachment 135165)
View in context: https://bugs.webkit.org/attachment.cgi?id=135165&action=review

This looks great to me! Since this adds new API we need the approval of one more GTK+ reviewer. I've CC'd some. One of them should be able to give the official r+.

I have just a couple nits below, but I think a committer could probably fix this up before landing without a problem.

> Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:661
> +    WebKitSecurityOrigin* securityOrigin = kit(coreOrigin);
> +    g_signal_emit_by_name(m_frame, "insecure-content-run", securityOrigin, url.string().utf8().data());

This could be one line.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:102
> +static void didRunInsecureContent(WebKitWebFrame*, WebKitSecurityOrigin*, const char*);

You probably want to include the "url" name on the last parameter, const char* is a generic type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list