[Webkit-unassigned] [Bug 82760] WebViewImpl doesn't notify the page that the user has canceled fullscreen.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82760


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134973|review?                     |review+
               Flag|                            |




--- Comment #7 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-04-02 12:29:03 PST ---
(From update of attachment 134973)
View in context: https://bugs.webkit.org/attachment.cgi?id=134973&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:1327
> +            doc->webkitCancelFullScreen();

if exiting fullscreen is initiated by JS calling document.webkitCancelFullScreen(),
then we will eventually reach this code again.  it looks like the second call to
webkitCancelFullScreen() will call webkitExitFullscreen().  in this case, do we
have to worry about a second webkitfullscreenchange event being generated?  it
looks like Document::addDocumentToFullScreenChangeEventQueue() could be called
more than once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.