[Webkit-unassigned] [Bug 82933] New: check-webkit-style errors when removing .png files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 13:20:34 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82933

           Summary: check-webkit-style errors when removing .png files
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fmalita at google.com
                CC: tony at chromium.org, pdr at google.com


After http://trac.webkit.org/changeset/112270, removing .png files triggers the following:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
ERROR: File does not exist: 'LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.png'


Looks like we're force-processing non-existent (removed) png files (patchreader.py:66):

            if not line_numbers:
                match = re.search("\s*png$", path)
                if match:
                    if call_only_once:
                        self._text_file_reader.process_file(file_path=path, line_numbers=None)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list