[Webkit-unassigned] [Bug 82928] New: Optimizing tracking of intruding floats being removed from RenderBlock during layout

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82928

           Summary: Optimizing tracking of intruding floats being removed
                    from RenderBlock during layout
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kenrb at chromium.org
                CC: hyatt at apple.com


This is a follow-up for bug 74056, for some performance improvements in special cases.

dhyatt's comment on https://bugs.webkit.org/show_bug.cgi?id=74056 --

> Not going to minus for this but thought of a couple of optimizations if you don't mind following up:
> 
> (1) If the oldIntrudingFloat set ever empties out, you can bail out of that last loop early.
> 
> In other words:
> 
> for (FloatingObjectSetIterator it = floatingObjectSet.begin(); it != end && !oldIntrudingFloatSet.isEmpty(); ++it)
>     oldIntrudingFloatSet.remove((*it)->m_renderer);
> 
> That way once the set gets emptied out, you don't waste time iterating over floats that you know won't be found in the set.
> 
> (2) If you cached an intruding object count and kept it up to date, you could really optimize the avoidsFloats case, since all it did was checked for if you had any intruding floats at all. Then you could make that case O(1) instead of O(n).
> 
> I won't minus, but I'd appreciate a follow-up bug and fixes for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.