[Webkit-unassigned] [Bug 78193] Inserting a paragraph between quoted lines in editing/deleting/delete-4038408-fix.html doesn't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78193


yi shen <yi.4.shen at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134857|0                           |1
        is obsolete|                            |
 Attachment #134857|review?                     |
               Flag|                            |
 Attachment #135138|                            |review?
               Flag|                            |




--- Comment #8 from yi shen <yi.4.shen at nokia.com>  2012-04-02 11:18:33 PST ---
Created an attachment (id=135138)
 --> (https://bugs.webkit.org/attachment.cgi?id=135138&action=review)
fix changelog & test failure on chromium 

In order to adjust position in ReplaceSelectionCommand and make it accessible by InsertParagraphSeparatorCommand, we have to call setEndingSelection() in ReplaceSelectionCommand, then InsertParagraphSeparatorCommand can retrieve the new position by calling the endingSelection(). However,  the position we pass to setEndingSelection() would be canonicalize, so the insertion position that can be seen by InsertParagraphSeparatorCommand may NOT be the desired one. 

For example,  we try to ask InsertParagraphSeparatorCommand to insert a paragraph separator in [Div, 1],    <div><blockquote>abc</blockquote>^<div>, after calling the setEndingSelection(), the insertion position changed to [Text, 3],  <div><blockquote>abc^</blockquote><div>. AS a result, the paragraph separator is insert into a unexpected place.

As a workaround, the new patch still use an extra parameter to provide the missing information for the InsertParagraphSeparatorCommand. Let me know if you have better idea to do it. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.