[Webkit-unassigned] [Bug 75553] [GTK][WK2] Initial FullScreen support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75553





--- Comment #47 from Philippe Normand <pnormand at igalia.com>  2012-04-02 06:00:03 PST ---
(From update of attachment 134767)
View in context: https://bugs.webkit.org/attachment.cgi?id=134767&action=review

>>> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:81
>>> +    bool fullScreenEnabled;
>> 
>> It seems this is only used inside #if ENABLE(FULLSCREEN_API) #endif blocks, so maybe we should add #if here?
> 
> For the naming of this perhaps "inFullScreenMode", "fullScreenModeActive", or "fullScreenActive" would make it clearer.
> 
> As an asides, it's a bit odd that in WebKit2 it's referred to as "FullScreen" (i.e. "full screen"), but the guard is "FULLSCREEN" (i.e. "fullscreen").

Ok I'll go for fullScreenModeActive :)

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:293
>> +            webkitWebViewBaseExitFullScreen(webViewBase);
> 
> I guess this will be an issue if a game wants to go fullscreen and use the 'f' key?

Hum what do you mean? This code is called only when the webview is already in full screen

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.