[Webkit-unassigned] [Bug 82847] Add mechanism for mapping from StyleRules back to fully constructed CSSStyleRules

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 04:03:39 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82847


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #135013|review?                     |review+
               Flag|                            |




--- Comment #9 from Andreas Kling <kling at webkit.org>  2012-04-02 04:03:38 PST ---
(From update of attachment 135013)
View in context: https://bugs.webkit.org/attachment.cgi?id=135013&action=review

r=me. Let's do this thing.

> Source/WebCore/css/CSSStyleSelector.cpp:2905
> +    const Vector<RefPtr<StyleSheet> >& styleSheets = document->styleSheets()->vector();
> +    for (unsigned i = 0; i < styleSheets.size(); ++i) {

You could use the iteration helpers of StyleSheetList directly here instead of grabbing the Vector. NABD.

> Source/WebCore/css/CSSStyleSelector.h:247
> +    CSSStyleRule* ensureFullCSSOMWrapperForStyleRule(StyleRule*);

As you mentioned, this could do with a scarier name, e.g ensureFullCSSOMWrapperForInspectorWhileUsingTerabytesOfMemory().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list